Add: Initial setup for mypy checking.#445
Merged
oscarlevin merged 7 commits intoPreTeXtBook:mainfrom Jun 20, 2023
Merged
Conversation
Member
|
This looks like a great start. As we discussed in drop-in, I'll wait for you to add more coverage before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This enables mypy type checking (a goal of #431), plus fixes types in
utils.py. I can extend this to fix all type errors mypy report -- should I keep going, or would you like to review these changes in more detail?To run:
mypy --install-types --non-interactive.The current list of type errors: